Add templates for InternalLinkBlock and ExternalLinkBlock - #108
Open
Manny2706 wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @Manny2706 There is no need to tag maintainers when you submit a PR. We are already receiving notifications about submissions, so tags just add notification noise. Thank you for your contribution though. We appreciate it. |
Contributor
Author
|
Got it, thanks for the clarification! I’ll avoid tagging maintainers in future PRs. Appreciate the feedback 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vossisboss,
This PR addresses part of issue #38 related to missing or malfunctioning block templates.
I’ve added a minimal template for
ExternalLinkBlockand aligned the existingInternalLinkBlocktemplate with the current structure. Both templates are placed undertemplates/components/streamfield/blocks/and follow the starter kit conventions using{% verbatim %}.I noticed that several other blocks are still pending, so I focused on these two to keep the contribution small and incremental.
I’d really appreciate your feedback on whether this approach aligns with the intended direction, and I’d be happy to continue working on the remaining blocks.
Thanks!
#AI usage
AI assistance was used to help review the implementation approach, validate the template logic, and draft parts of the pull request description.
Closes #38