Fix duplicate banner landmark: replace second <header> with <div> (#333). Fix #328, #328, #331 - #333
Merged
thibaudcolas merged 3 commits intoJul 3, 2026
Conversation
4 tasks
Replaces the second `<header>` element in layout.html with a `<div>` to resolve the axe accessibility rule `landmark-no-duplicate-banner`. The second header (containing breadcrumbs and theme controls) was being treated as a banner landmark alongside the primary site header. Since it already includes a `<nav>` via breadcrumbs.html, a plain `<div>` is sufficient. Fixes #327. Also fixes #325 #328 #331.
Copilot
AI
changed the title
[WIP] Fix accessibility issue with multiple banner landmarks on admonitions page
Fix duplicate banner landmark: replace second Jul 3, 2026
<header> with <div>
thibaudcolas
marked this pull request as ready for review
July 3, 2026 13:58
Member
|
@copilot pls add a |
Contributor
Author
Done — added an |
thibaudcolas
changed the title
<header> with <div><header> with <div> (#333). Fix #328, #328, #331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages had two
<header>elements, both mapped as ARIA banner landmarks by assistive technologies — violating thelandmark-no-duplicate-bannerbest practice.Change
sphinx_wagtail_theme/layout.html: The inner<header class="row align-items-baseline">(containing breadcrumbs and theme controls) is changed to a<div>. The breadcrumbs already render a<nav>, so no semantic information is lost.The primary site
<header class="container-fluid bg-primary">remains unchanged as the sole banner landmark.Also addresses related landmark violations #325, #328, #331.