-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Enhance Drag-N-Drop README with Internal Drag and Drop Info
#4869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added details about internal drag and drop functionality.
WalkthroughDocumentation updates: README for the drag-n-drop example was revised to replace the "See also" section with an "HTML5 Drag and Drop API" section and add instructions to scroll to the "Internal Drag and Drop" demo; UNRELEASED_CHANGELOG.md was updated to reference the README change. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @v3/UNRELEASED_CHANGELOG.md:
- Line 22: Fix the grammatical mismatch in the UNRELEASED_CHANGELOG.md entry for
the "Drag N Drop" example by changing "and highlights that `Internal Drag and
Drop` is demonstrated with the example" to a parallel form such as "and
highlight that `Internal Drag and Drop` is demonstrated with the example"; also
append a PR reference for traceability (e.g., "PR #<number>") next to the GitHub
handle @ndianabasi so the line becomes something like: Update the README for the
`Drag N Drop` example and highlight that `Internal Drag and Drop` is
demonstrated with the example — @ndianabasi (PR #<number>).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
v3/UNRELEASED_CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Run Go Tests v3 (macos-latest, 1.24)
- GitHub Check: Run Go Tests v3 (windows-latest, 1.24)
- GitHub Check: Run Go Tests v3 (ubuntu-latest, 1.24)
- GitHub Check: semgrep-cloud-platform/scan
|
|
||
| ## Changed | ||
| <!-- Changes in existing functionality --> | ||
| - Update the README for the `Drag N Drop` example and highlights that `Internal Drag and Drop` is demonstrated with the example @ndianabasi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammar and add PR reference for consistency.
The entry has a grammatical error with mismatched parallel structure ("and highlights" should be "and highlight" or restructured). Additionally, per the example entries in the guidelines (lines 40–50), PR references should be included for traceability.
✏️ Proposed fix
-- Update the README for the `Drag N Drop` example and highlights that `Internal Drag and Drop` is demonstrated with the example @ndianabasi
+- Update the README for the `Drag N Drop` example to highlight that `Internal Drag and Drop` is demonstrated with the example (#4869)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Update the README for the `Drag N Drop` example and highlights that `Internal Drag and Drop` is demonstrated with the example @ndianabasi | |
| - Update the README for the `Drag N Drop` example to highlight that `Internal Drag and Drop` is demonstrated with the example (#4869) |
🤖 Prompt for AI Agents
In @v3/UNRELEASED_CHANGELOG.md at line 22, Fix the grammatical mismatch in the
UNRELEASED_CHANGELOG.md entry for the "Drag N Drop" example by changing "and
highlights that `Internal Drag and Drop` is demonstrated with the example" to a
parallel form such as "and highlight that `Internal Drag and Drop` is
demonstrated with the example"; also append a PR reference for traceability
(e.g., "PR #<number>") next to the GitHub handle @ndianabasi so the line becomes
something like: Update the README for the `Drag N Drop` example and highlight
that `Internal Drag and Drop` is demonstrated with the example — @ndianabasi (PR
#<number>).



Description
This PR improves the README for the
Drag-N-Dropexample to highlight and highlights that Internal Drag and Drop is demonstrated within the example.Fixes # (issue)
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.