Update encode method to use type hinting for string|Response object#1150
Open
joanhey wants to merge 6 commits intowalkor:masterfrom
Open
Update encode method to use type hinting for string|Response object#1150joanhey wants to merge 6 commits intowalkor:masterfrom
joanhey wants to merge 6 commits intowalkor:masterfrom
Conversation
We can improve this method.
…Contains parameter
We need to check it later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Available from PHP 8.0.
EDIT:
string|Response|ServerSentEventsPD: later we need to check the
TcpConnection::send()why the$sendBufferreceivenull.For now use a fast fix
$sendBuffer ??= '';