feat: Add amd/arm64 for the docker image artifacts#84
feat: Add amd/arm64 for the docker image artifacts#84sqaisar wants to merge 1 commit intowandb:mainfrom
Conversation
WalkthroughThis pull request updates the GitHub release workflow and the Dockerfile. The workflow now utilizes the Changes
Sequence Diagram(s)sequenceDiagram
actor Developer
participant Workflow as GH Workflow
participant BuildAction as Docker Build-Push Action
participant Registry as Docker Registry
Developer->>Workflow: Trigger release workflow
Workflow->>BuildAction: Execute multi-arch build step
BuildAction->>Registry: Push built images (linux/amd64, linux/arm64)
Registry-->>BuildAction: Confirm image push
BuildAction-->>Workflow: Return success result
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
sqaisar
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
53-53: Action Version Update NoticeStatic analysis has flagged that the current reference to
docker/build-push-action@v4might be using an outdated runner. Please consider updating this to the latest stable patch version (for example,docker/build-push-action@v4.x) to ensure full compatibility with GitHub Actions runners.🧰 Tools
🪛 actionlint (1.7.4)
53-53: the runner of "docker/build-push-action@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release.yaml(1 hunks)Dockerfile(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/release.yaml
53-53: the runner of "docker/build-push-action@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (2)
Dockerfile (1)
28-28: Dynamic Build Command UsageThe build command now uses
GOOS=${TARGETOS}andGOARCH=${TARGETARCH}instead of hardcoded values. This update ensures the binary is built for the appropriate target platform, supporting multi-architecture builds as intended by the PR objectives..github/workflows/release.yaml (1)
52-63: Multi-Arch Image Build & Tag ConfigurationThe new "Build and Push Multi-arch Images" step leverages the
docker/build-push-action@v4action to build images for bothlinux/amd64andlinux/arm64. The dynamic tagging using release outputs is cleanly integrated and aligns with the PR objectives for supporting multiple architectures and repository updates.🧰 Tools
🪛 actionlint (1.7.4)
53-53: the runner of "docker/build-push-action@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
sqaisar
changed the title
sqaisar
changed the title
sqaisar
force-pushed
the
feat/multiarch-image
branch
from
7a24959 to
b570145
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yaml (1)
52-53: Update Docker Build-Push Action VersionThe "Build and Push Multi-arch Images" step currently uses
docker/build-push-action@v4, but static analysis indicates that this version may be outdated for the current GitHub Actions environment. Consider upgrading to a newer version (for example,docker/build-push-action@v5) to leverage the latest features and improvements.- uses: docker/build-push-action@v4 + uses: docker/build-push-action@v5🧰 Tools
🪛 actionlint (1.7.4)
53-53: the runner of "docker/build-push-action@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release.yaml(1 hunks)Dockerfile(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- Dockerfile
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/release.yaml
53-53: the runner of "docker/build-push-action@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (1)
.github/workflows/release.yaml (1)
54-63: Verify Multi-Arch Build Configuration and TaggingThe multi-architecture build configuration is well structured—with the build context set to the repository root, pushing enabled, and target platforms specified as
linux/amd64,linux/arm64. The dynamic tag expressions (using release output values) are also aligned with the updated versioning scheme. Please ensure that the preceding release step properly generates the expected output values so that the tagging behaves as intended.
1 participant
Summary by CodeRabbit
New Features
Chores