Add Maho environment support - #941
Open
fballiano wants to merge 1 commit into
Open
Conversation
fballiano
force-pushed
the
add-maho-environment
branch
from
July 20, 2026 15:27
4e6c593 to
15a5ad7
Compare
This was referenced Jul 20, 2026
fballiano
force-pushed
the
add-maho-environment
branch
from
July 20, 2026 15:30
15a5ad7 to
7385e53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Is your feature request related to a problem? Please describe.
Maho is an open source ecommerce platform forked from OpenMage / Magento 1 and modernized (PHP 8.3+, no Zend/Varien, Symfony components). I am its maintainer. Warden has no environment type that fits it: the
magento1type assumes the webroot is the project root and pulls Magento-specific php-fpm image variants plus Redis, while Maho serves frompublic/, uses the generic php-fpm images, and deliberately needs no Redis, Varnish, Elasticsearch or OpenSearch (caching via Symfony Cache, sessions on files/db, catalog search on database fulltext; its composer.json even conflicts with the Magento Redis packages).Describe the solution you've submitted
A new
mahoenvironment type following the same file layout as thecakephptype (added in #785):maho.base.yml:NGINX_PUBLIC=/public,NGINX_TEMPLATE=maho.conf, andMAGE_IS_DEVELOPER_MODE=1on php-fpm/php-debug (Maho honors this env var, inherited from Magento 1)init.env: PHP 8.5, Composer 2, Node 24, MariaDB 12.2 (the newest published wardenenv images),WARDEN_DB=1and everything else (redis, varnish, elasticsearch, opensearch, rabbitmq) offdb.base.yml:mahodatabase/user/password defaults with the usual mysqld flagsmaho.darwin.yml+maho.mutagen.yml: same appdata/Mutagen scheme as cakephp, with Maho'svar/directory (cache, logs, sessions, locks) excluded from synccommands/env-init.help: added amahostanzaCHANGELOG.mdentryNo changes to
commands/env.cmdare needed: type discovery is directory-driven and the^magentophp-image-variant regex correctly does not matchmaho, so the genericwardenenv/php-fpmimages are used.Requires the nginx template added in wardenenv/images#122.
Describe alternatives you've considered
Reusing the
magento1type: wrong webroot (project root instead ofpublic/), Magento-specific php-fpm image variants that Maho does not need, and Redis enabled by default which conflicts with Maho's composer setup.Additional context
Verification done so far:
fetchValidEnvTypesfrom this checkout'sutils/env.shnow returns... magento2 maho shopware ...(discovery is directory-driven, so no shell changes were needed)wardenenv/nginx:1.27image withNGINX_TEMPLATE=maho.confandNGINX_PUBLIC=/public, the image's envsubst step was run andnginx -tpassesUntil the images PR is merged and the nginx image republished, the type can be tested end to end by bind-mounting
maho.confover/etc/nginx/available.d/maho.confthrough a project's.warden/warden-env.yml.