Fix agent tips not appearing below the warping indicator

[warp-dev-github-integration]

Description

The rotating agent tips that normally render below the "Warping..." text in Agent Mode stopped appearing.

Root cause: PR #9297 (commit 76cccd24d, "Clip warping-indicator chips so they don't overflow narrow panes") wrapped the warping indicator's row in a Clipped element so the action chips don't overflow into the adjacent pane on narrow widths. That row sits inside a ConstrainedBox whose height was already fixed to a single line of text. Before the clip was added, the tip rendered on a second line and simply overflowed the fixed-height box visibly. Once the row was clipped to the box's bounds, that second line — the agent tip (and the fallback-model explanation, which uses the same secondary_element slot) — was clipped away entirely.

Fix: In render_warping_indicator_base (app/src/ai/blocklist/block/view_impl/common.rs), reserve room for the secondary line in the footer height when a secondary_element is present, so the clip no longer hides it while still clipping the chips horizontally as intended. The height math is extracted into a small pure helper warping_footer_height(monospace_font_size, has_secondary_element).

Linked Issue

Reported in Slack (factory-client bug-triage): see thread link below. No GitHub issue.

Testing

• Added a regression unit test warping_footer_height_reserves_a_line_for_the_secondary_element in common_tests.rs that asserts the footer reserves an extra line (secondary font size + 1px margin) when a secondary element is present. It fails against the old single-line height and passes with the fix.
• cargo nextest run -p warp warping_footer_height — passes.
• cargo clippy -p warp --lib --no-deps — clean.
• Manual UI verification (computer use) on a running debug build — done. Launched the authenticated warp build, started an agent, and confirmed:
  • Normal width: a tip line renders directly below Warping... (e.g. Tip: /new to start a new agent conversation with clean context. Learn more) and is fully visible, not clipped. Tips rotate as expected.
  • Narrow pane: the tip still renders (horizontally ellipsized to fit) and the action chips stay within the pane — i.e. Clip warping-indicator chips so they don't overflow narrow panes #9297's chip-clipping is preserved alongside the restored tip.
  • Screenshots (normal + narrow width) are attached in the linked Slack thread.

Screenshots / Videos

Verification screenshots (normal-width tip restored; narrow-pane tip + chips) are posted in the linked Slack thread below.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fix the rotating agent tips not appearing below the "Warping..." indicator in Agent Mode.

Slack thread: https://warpdev.slack.com/archives/C0BCE7AELJ2/p1782518640801369?thread_ts=1782518640.801369&cid=C0BCE7AELJ2

[oz-for-oss]

@warp-dev-github-integration[bot]

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR adjusts the warping indicator footer height so the secondary line used for agent tips and fallback-model messaging is no longer clipped, and adds a focused regression test for the height helper. I did not find security issues or material spec drift; no approved spec context was provided.

Concerns

• For this user-facing UI change, no screenshot or screen recording is attached in the PR description demonstrating the fixed state. A Slack thread reference to the original bug screenshot does not provide reviewable end-to-end evidence for the PR. Please include screenshots or a short recording showing the tip or fallback explanation rendering below Warping..., including a narrow-pane case where the action chips are still clipped correctly.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[warp-dev-github-integration]

Addressed the review's concern about missing visual evidence. I ran the fix end-to-end on a running debug build (computer use) and confirmed:

• Normal width: the tip renders directly below Warping... (e.g. Tip: /new to start a new agent conversation with clean context. Learn more) and is fully visible — not clipped.
• Narrow pane: the tip still renders (horizontally ellipsized to fit) and the action chips stay inside the pane, so Clip warping-indicator chips so they don't overflow narrow panes #9297's chip-clipping behavior is preserved alongside the restored tip.

The Testing section has been updated with these results, and the normal-width + narrow-width screenshots are attached in the linked Slack thread. (They live in Slack rather than inline here because this PR was driven from the factory-client triage thread.)