Block running ADBD as root and remove some restrictions built in the "run-as" utility#22
Closed
ChrysoliteAzalea wants to merge 1 commit intowaydroid:lineage-18.1from
Closed
Conversation
This was referenced Jul 24, 2023
c8bd822 to
0e416c6
Compare
Member
|
Please split the two patches |
Member
|
Also force this to |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone! I propose patching ADBD to unconditionally block restarting as root, and
run-asto remove some restrictions.The reason for unconditionally blocking restarting ADBD as root is that it allows an unprivileged user to enable the "Rooted debugging" option and use the
adb rootcommand in order to get root shell (and it runs as an actual root UID since the container is privileged, however, it's restricted due to security options enabled in LXC container config), and there is no way for the administrator to prevent that. Privileged things that require root can be done with thewaydroid shellsubcommand (or with Magisk) that require either root, or initial privileged setup.Removing restrictions in the
run-asutility by patching the utility itself is also a far cleaner way to enhance its usefulness than tampering with the package list, and is less likely to introduce problems.