Removing the "Disable ADB secure" patch

[ChrysoliteAzalea]

Hello everyone! I propose enabling the ro.adb.secure property.

Explanation:

Android Debug Bridge is a tools that allows remote communication with the Android system. On the Android system side, it's represented by the Android Debug Bridge Daemon, that runs as a special user (shell). ro.adb.secure is a property that allows ADBD to be managed by Android settings. If ro.adb.secure is set to 0, anyone that can connect to the Android system over network (including installed Android apps connecting to 127.0.0.1) can get access to the privileged shell with lots of irrevocable Android permissions, and remotely control the system through tools like scrcpy. If it's set to 1, all such interactions have to be authorized by the user -- it cannot be done over network.

Possible benefits:

• ADB can be disabled in the settings (without re-enabling on container restart)
• ADB connections have to be authorized by user
• Such authorizations can be revoked

Possible problems:

I haven't found any.

[aleasto]

Yea I'm not sure why we're carrying these

[lnee94]

You may be able to enable adb root which you could make a setuid binrary which would allow for root on for all with adb