Skip to content

Use go mod and keep all build steps in docker #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SamLR wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use go mod and keep all build steps in docker #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c828cc1
Use a go mod and upgrade stuff
Sep 21, 2021
00935e9
TMP -- get stuff working on a mac
Nov 11, 2021
9985ef3
TMP more fixes
Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ defaults: &defaults
working_directory: /go/src/github.com/weaveworks/launcher
docker:
# 1.10.0 and dnsName: https://github.com/golang/go/issues/23995
- image: circleci/golang:1.9
- image: circleci/golang:1.16

# Environment for integration testing
integration_test_defaults: &integration_test_defaults
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
- setup_remote_docker
- run: make dep
- run: go test ./bootstrap
- run: make bootstrap
- run: make build/.bootstrap.done
- deploy:
name: Push binaries to S3
command: |
Expand All @@ -138,7 +138,7 @@ jobs:
name: Push image
command: |
sudo apt-get update -qq
sudo apt-get -y -qq install python-pip
sudo apt-get -y -qq install python3-pip
sudo pip install awscli # The apt package doesn't support --no-include-email
mkdir ~/.aws
echo $AWS_ECR_CREDENTIALS | base64 -d > ~/.aws/credentials
Expand Down Expand Up @@ -190,7 +190,6 @@ jobs:
<<: *integration_test_defaults
working_directory: "~/.go_workspace/src/github.com/weaveworks/launcher"
environment:
GO111MODULE: "off"
GOPATH: "/home/circleci/.go_workspace"
steps:
- start_integration_env:
Expand Down
Loading