Open
Conversation
- `default` looks a bit more consistent for now
- Remove /profiles and /params endpoints
- They just return a post-filtered subset of /templates/{name}
- Align preview and create-pull-request endpoints, they had differing
param names
- createpullrequest.values -> profiles (aligned w/ preview.profiles)
- preview.values -> parameter_values (aligned w/
createpullrequest.parameter_values)
- Hopefully we can just use the OSS one
Also external_secret_name -> name
foot
added
the
exclude from release notes
AlinaGoaga
approved these changes
Dec 5, 2023
Contributor
There was a problem hiding this comment.
Tested, LGTM 🥳 Unrelated to the changes in this PR (already on https://demo-01.eng-sandbox.weave.works/) I've noticed that when you click PR Preview in Secret Creation, if there are missing params, it doesn't flag the missing field (there's no feedback to the user). The other sections seem ok. Will log a ticket for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Tidy up the templates APIs
createpullrequest.values->profiles(aligned w/preview.profiles)preview.values->parameter_values(aligned w/createpullrequest.parameter_values)Small fix to secrets param in the path:
external_secret_name->name