Added Credit class to commerce vocab and context#24
Closed
melvincarvalho wants to merge 1 commit intoweb-payments:masterfrom
melvincarvalho:master
Closed
Added Credit class to commerce vocab and context#24melvincarvalho wants to merge 1 commit intoweb-payments:masterfrom melvincarvalho:master
melvincarvalho wants to merge 1 commit intoweb-payments:masterfrom
melvincarvalho:master
Conversation
Author
|
Closed ... Will edit source instead of the actual html |
Author
|
Oh wait, maybe the source is something different ... hmm if I could get some feedback on this, that'd be great ... |
Member
|
Closing this PR since #25 took care of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a Credit class to the commerce vocab and description to distinguish between a Transfer and a Credit (IOU).
I have NOT yet changed the example to reflect the new class, but the changes are minimal. I can do this either after this pull request is reviewed, or as a single change.
Also changed is the context to let Credit be mapped to com:Credit