Skip to content

script: Prevent panic on multiple calls to MessagePort::close#58886

Open
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_43553
Open

script: Prevent panic on multiple calls to MessagePort::close#58886
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo:servo_export_43553

Conversation

@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

@servo-wpt-sync servo-wpt-sync commented Mar 31, 2026 •
edited
Loading

Converted ManagedMessagePort from a struct to an enum with Enabled and Disabled variants.

Testing: ran ./mach test-wpt tests/wpt/tests/webmessaging/message-channels/close.any.js result: ```web-platform-test

Ran 18 checks (16 subtests, 2 tests)
Expected results: 18
Unexpected results: 0
OK
```

Fixes #<!-- nolink -->36765

Reviewed in servo/servo#43553

@servo-wpt-sync servo-wpt-sync mentioned this pull request Mar 31, 2026
Open
wpt-pr-bot
wpt-pr-bot approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@sabbCodes @servo-wpt-sync
script: Made MessagePort.close() idempotent by making ManagedMessageP…
6725210 
…ortDom an enum

Signed-off-by: Sabb <sarafaabbas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees

No one assigned

Labels

do not merge yet servo-export webmessaging wg-s_htmlwg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@servo-wpt-sync @wpt-pr-bot @sabbCodes