Fix WPT version of scroll-timeilne-snapshotting test#58909
Open
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Open
Fix WPT version of scroll-timeilne-snapshotting test#58909chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
The original test has implicit timing assumptions about when events would be dispatched relative to animation frame timing. This test was also failing on webkit, which supports SDA. The updated test, has fewer moving parts (pun intended) and works with or without the snapshot post layout experiment. Fixing as part of Interop 2026 Bug: 384523570 Change-Id: I84c223d7ca8e8aa1c238bd5b099f94a8712c33aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718838 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1609258}
e9ab052 to
b6e42ec
Compare
wpt-pr-bot
approved these changes
Apr 2, 2026
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original test has implicit timing assumptions about when
events would be dispatched relative to animation frame timing. This
test was also failing on webkit, which supports SDA.
The updated test, has fewer moving parts (pun intended) and works with
or without the snapshot post layout experiment.
Fixing as part of Interop 2026
Bug: 384523570
Change-Id: I84c223d7ca8e8aa1c238bd5b099f94a8712c33aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718838
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609258}