Skip to content

maps "caret-shape" web feature#58924

Open
ChrisC wants to merge 1 commit intoweb-platform-tests:masterfrom
bocoup:wf-caret-shape
Open

maps "caret-shape" web feature#58924
ChrisC wants to merge 1 commit intoweb-platform-tests:masterfrom
bocoup:wf-caret-shape

Conversation

@ChrisC
Copy link
Copy Markdown
Contributor

@ChrisC ChrisC commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to merge as is, though I am making a suggestion for a possible improvement.

Comment on lines 40 to +43
- caret-eol-*
- name: caret-shape
files:
- caret-shape-*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical, but arguably, the caret-eol-* files belong to caret-shape slightly more than caret-color.

Suggested change
- caret-eol-*
- name: caret-shape
files:
- caret-shape-*
- name: caret-shape
files:
- caret-shape-*
- caret-eol-*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants