fix: Global wait not working with toBeDisplayed#2023
Open
dprevost-LMI wants to merge 7 commits intowebdriverio:mainfrom
Open
fix: Global wait not working with toBeDisplayed#2023dprevost-LMI wants to merge 7 commits intowebdriverio:mainfrom
toBeDisplayed#2023dprevost-LMI wants to merge 7 commits intowebdriverio:mainfrom
Conversation
This was referenced Feb 14, 2026
Member
|
Merged #2010 .. I hope this didn't cause this massive conflict 🙈 |
Contributor
Author
|
It's normal. I based myself on it to use the playground. I'll rebase and drop the conflicting commits! |
cd3780b to
8c27a61
Compare
8004226 to
07cf00f
Compare
Contributor
Author
|
@christian-bromann ready! Do you mind triggering a release with this one so we can fix all known issues and use it in the webdriverio project? |
This was referenced Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2020
The
index.ts#setDefaultOptionsmethod sets a global configuration in a way that is not obvious when making code changes to matchers, which leads to the issue mentioned above.This PR fixes the regression, adds unit and integration tests, and adds a prevention mechanism to better account for the global configuration.
setDefaultOptionsto allow multiple different global DEFAULT_OPTION constants to be modified and ease their usage as default value in the matchar's function signaturesetDefaultOptionssetOptionsin favour ofsetDefaultOptionsWaiting for the merge of: #2010