Added sensible keybindings to DraftState#92
Open
themamiza wants to merge 2 commits into
Open
Conversation
`delete_word_backward` added to DraftState helpers
Add a `DraftAction` layer that maps raw key events into draft editing operations before applying them to the draft. This makes shortcut handling reusable as more bindings are added. Common keybindings have been added: C-a -> Move to the beginning of the line C-e -> Move to the end of the line C-w, C-h -> Delete word backward
Contributor
|
From what I can tell, #75 covers that. Could you double-check and let me know if it satisfies what you added here 🙏? |
Author
|
Yes that implementation is pretty much it, except that Ctrl-h (which is passed when doing Ctrl-Backspace) should be mapped to DeleteWordBackward as that's the correct behavior in emacs and most other editors (same behavior as Ctrl-w). |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds missing draft shortcuts that are common for text editing.
Added
delete_word_backwardtoDraftStateand introducedDraftActionso adding more draft shortcuts is easier and cleaner.Ctrl-Backspace (passed as Ctrl-h) and Ctrl-w delete the previous word, Ctrl-a moves the cursor to the beginning of the line and
Ctrl-e moves the cursor to the end of the line.