Skip to content

Comments

convert website to package and use vite#124

Open
adbenitez wants to merge 9 commits intomainfrom
adb/improvements2
Open

convert website to package and use vite#124
adbenitez wants to merge 9 commits intomainfrom
adb/improvements2

Conversation

@adbenitez
Copy link
Contributor

  • add package.json to manage dependencies
  • remove manual bulma framework files, import package as dependency instead
  • use vite for code shrinking and bundling, as well as easy hot-reloading while developing
  • setup prettier for automatic code formatting

prettier was setup but code was not re-formatted as part of this PR to avoid making it hard to review, in a next PR code can be formatted and checking code format be enabled in the CI

@adbenitez adbenitez requested review from hpk42 and r10s February 15, 2026 00:38
@adbenitez adbenitez self-assigned this Feb 15, 2026
@adbenitez adbenitez requested a review from nicodh February 15, 2026 00:38
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

The packaging makes sense. There is an issue with the arrow buttons not being well centered see PR #126 which should be merged before reformating all files with prettierignore

Added a suggestion to add the dist folder to prettierignore

@hpk42
Copy link
Contributor

hpk42 commented Feb 15, 2026

I was pretty happy having a page that does not require
node to be honest.

@nicodh
Copy link
Contributor

nicodh commented Feb 15, 2026

I was pretty happy having a page that does not require node to be honest.

Ah - I thought that was discussed and agreed on before.

As a base for a discussion/decision: the benefits of a bundler are mainly:

  • use the npm package of bulma instead a static file that may or may not be up to date
  • a "bit" of reducing the file sizes (not really an issue for such a small page)
  • cache bursting links to assets (also not an issue if the page gets updated rarely)
  • "hot reloading" - no need to press F5 :-)
  • strict and consistent code formatting with prettier

All in all - not very strong arguments on the pro side but there are also not too strong cons imo

Co-authored-by: Nico de Haen <mail@ndh-websolutions.de>
@adbenitez adbenitez changed the base branch from adb/improvements to main February 15, 2026 15:36
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for a decision first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants