Open
Conversation
nicodh
reviewed
Feb 15, 2026
nicodh
approved these changes
Feb 15, 2026
Contributor
There was a problem hiding this comment.
Lgtm
The packaging makes sense. There is an issue with the arrow buttons not being well centered see PR #126 which should be merged before reformating all files with prettierignore
Added a suggestion to add the dist folder to prettierignore
Contributor
|
I was pretty happy having a page that does not require |
Contributor
Ah - I thought that was discussed and agreed on before. As a base for a discussion/decision: the benefits of a bundler are mainly:
All in all - not very strong arguments on the pro side but there are also not too strong cons imo |
Co-authored-by: Nico de Haen <mail@ndh-websolutions.de>
nicodh
reviewed
Feb 15, 2026
Contributor
nicodh
left a comment
There was a problem hiding this comment.
Let's wait for a decision first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prettier was setup but code was not re-formatted as part of this PR to avoid making it hard to review, in a next PR code can be formatted and checking code format be enabled in the CI