Bluetooth CLI actions, pair/trust connect #234

zamderax · 2025-12-27T06:21:02Z

Summary

add Bluetooth CLI commands for connect/list/disconnect/forget with interactive defaults
add agent support for pair/trust/forget plus updated Bluetooth RPCs
update Noora dependency and improve dev-update agent script

IMPORTANT It requires: wendylabsinc/meta-wendyos-jetson#20 SPECIFICALLY NEEDS HOST TO HAVE BLUEZ running!

Testing

Whenever we release a wendy os install --nightly where bluez is available you can test this agent and cli

codecov · 2025-12-27T06:27:39Z

Codecov Report

❌ Patch coverage is 5.86531% with 1300 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
Sources/Wendy/cli/commands/BluetoothCommand.swift	2.63%	592 Missing ⚠️
...ources/WendyAgent/Services/WendyAgentService.swift	0.00%	310 Missing ⚠️
Sources/WendyAgent/Services/BluetoothManager.swift	17.85%	299 Missing ⚠️
Sources/Wendy/cli/commands/WiFiCommand.swift	0.00%	50 Missing ⚠️
Sources/Wendy/CLI+Support.swift	0.00%	49 Missing ⚠️

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   15.41%   14.71%   -0.70%     
==========================================
  Files         104      106       +2     
  Lines       17120    18493    +1373     
==========================================
+ Hits         2639     2722      +83     
- Misses      14481    15771    +1290

Flag	Coverage Δ
Linux	`12.18% <5.86%> (-0.56%)`	⬇️
macOS	`15.65% <5.89%> (-0.77%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
Sources/Wendy/cli/commands/DeviceCommand.swift	`0.00% <ø> (ø)`
Sources/Wendy/CLI+Support.swift	`0.00% <0.00%> (ø)`
Sources/Wendy/cli/commands/WiFiCommand.swift	`0.00% <0.00%> (ø)`
Sources/WendyAgent/Services/BluetoothManager.swift	`17.85% <17.85%> (ø)`
...ources/WendyAgent/Services/WendyAgentService.swift	`0.00% <0.00%> (ø)`
Sources/Wendy/cli/commands/BluetoothCommand.swift	`2.63% <2.63%> (ø)`

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Joannis · 2025-12-27T10:53:44Z

Proto/wendy/agent/services/v1/wendy_agent_v1_service.proto

+
+    // List available Bluetooth devices (uses BlueZ)
+    rpc ListBluetoothDevices(ListBluetoothDevicesRequest) returns (ListBluetoothDevicesResponse);
+
+    // Start Bluetooth discovery scan
+    rpc StartBluetoothScan(StartBluetoothScanRequest) returns (StartBluetoothScanResponse);
+
+    // Stop Bluetooth discovery scan
+    rpc StopBluetoothScan(StopBluetoothScanRequest) returns (StopBluetoothScanResponse);
+
+    // Connect to a Bluetooth device
+    rpc ConnectBluetoothDevice(ConnectBluetoothDeviceRequest) returns (ConnectBluetoothDeviceResponse);
+
+    // Disconnect from a Bluetooth device
+    rpc DisconnectBluetoothDevice(DisconnectBluetoothDeviceRequest) returns (DisconnectBluetoothDeviceResponse);
+
+    // Forget (remove) a Bluetooth device
+    rpc ForgetBluetoothDevice(ForgetBluetoothDeviceRequest) returns (ForgetBluetoothDeviceResponse);


Would be nice to bundle this in a new service proto

Joannis · 2025-12-27T10:54:05Z

Proto/wendy/agent/services/v1/wendy_agent_v1_service.proto

+        bool connected = 5;
+
+        // Device type/class (e.g., "audio-headset", "keyboard", "mouse")
+        string device_type = 6;


Is there a known enum we can reflect here?

Yes, I will make a task for this in Linear to track it, will address in a future PR.

Joannis · 2025-12-27T10:55:44Z

Sources/WendyAgent/Services/BluetoothManager.swift

+        let effectiveTimeoutSeconds =
+            timeoutSeconds == 0 ? Self.defaultScanTimeoutSeconds : timeoutSeconds
+
+        _ = Task.detached { [logger, self] in


This doesn't need to be a (detached) background task. Can we just call this inline?

Joannis · 2025-12-27T10:56:49Z

Sources/WendyAgent/Services/BluetoothManager.swift

+        if timeoutSeconds > 0 {
+            Task { [logger] in


It would be worth having a func run() async throws on BluetoothManager, so we can signal the run-loop with start/stop commands in a structured way. If two calls happen simultaneously, both asking to scan with timeout, they'll conflict.

Joannis · 2025-12-27T10:59:52Z

Sources/Wendy/cli/commands/BluetoothCommand.swift

+                signalSource.cancel()
+                signal(SIGINT, SIG_DFL)
+                Task {
+                    _ = try? await agent.stopBluetoothScan(.init())


This doesn't work, the signal will happen immediately and not wait for the Task. You wan tto queue the signal after running this stopBluetoothScan.

Joannis · 2025-12-27T11:00:59Z

Sources/Wendy/cli/commands/BluetoothCommand.swift

+                }
+
+                guard let targetDevice else {
+                    return


Maybe a warning?

zamderax · 2025-12-28T09:38:56Z

@Joannis I added ResponseStatus (success/info/warning/error) and corresponding logs so WiFi/Bluetooth operations can return typed status messages to the CLI.

- Fix race condition in BluetoothCommand.swift where defer block used fire-and-forget Task for stopBluetoothScan, causing the function to return before scan was actually stopped - Convert BluetoothManager from struct to actor for proper concurrency - Add run() method for structured lifecycle management - Track scanTask to prevent concurrent scan conflicts - Handle CancellationError gracefully when scans are stopped early

Joannis · 2025-12-29T10:05:25Z

Proto/wendy/agent/services/v1/wendy_agent_v1_service.proto

+        INFO = 2;
+        WARNING = 3;


What do INFO and WARNING mean? Are they successful status codes?

Joannis · 2025-12-29T10:07:11Z

Sources/Wendy/CLI+Support.swift

+func responseStatusLevelDescription(
+    _ level: Wendy_Agent_Services_V1_ResponseStatus.Level
+) -> String {


Suggested change

func responseStatusLevelDescription(

_ level: Wendy_Agent_Services_V1_ResponseStatus.Level

) -> String {

extension Wendy_Agent_Services_V1_ResponseStatus.Level: CustomStringConvertible {

public var description: String {

zamderax · 2025-12-30T08:22:55Z

Addressed Joannis notes:\n- Documented ResponseStatus levels (INFO/WARNING are successful with extra context).\n- Added CustomStringConvertible for ResponseStatus.Level and updated CLI JSON/text output to use it.\n- Bluetooth CLI SIGINT: stop scan inline and re-raise SIGINT after cleanup; removed detached stop-scan tasks.\n- Added a warning when no device is selected (disconnect/forget).\n\nBluetoothManager already has a run() loop + scanGeneration guard to prevent overlapping scan requests; can wire it into ServiceGroup if you want.

Joannis · 2025-12-30T10:38:57Z

Sources/WendyAgent/Services/BluetoothManager.swift

+        // The run loop keeps the actor alive and allows for structured concurrency.
+        // When cancelled, any active scan task will be cancelled as well.
+        defer {
+            scanTask?.cancel()
+            scanTask = nil
+        }
+
+        // Wait indefinitely until cancelled
+        try await Task.sleep(for: .seconds(Int64.max))


This still uses unstructured tasks with background logic.

Right now, if I don't use it, the wendy-agent hangs. Let me investigate further.

mihai-chiorean · 2026-01-13T21:58:24Z

Scripts/dev-update-agent-hard-scp.sh

-read -p "Enter hostname [wendyos-merry-aurora.local]: " HOSTNAME
-HOSTNAME=${HOSTNAME:-wendyos-merry-aurora.local}
-USER=edgeos
+HOSTNAME=wendyos-spirited-rose.local


host and user/password are hardcoded. I'd remove at least the user/password and let them be passed in interactively

zamderax requested a review from a team as a code owner December 27, 2025 06:21

Joannis reviewed Dec 27, 2025

View reviewed changes

zamderax added 5 commits December 28, 2025 23:10

Add Bluetooth CLI actions and pairing support

fc75a46

Add Bluetooth parsing and display name tests

8e044b5

Add response status and CLI warnings

1dce112

Format WiFi command

21c4d5e

zamderax force-pushed the wdy-617-bluetooth-connect-list-disconnect-forget branch from 732d630 to 21c4d5e Compare December 29, 2025 07:11

Joannis reviewed Dec 29, 2025

View reviewed changes

Address PR #234 review feedback

c01c862

Joannis reviewed Dec 30, 2025

View reviewed changes

adding easier scp

89eb5fd

mihai-chiorean reviewed Jan 13, 2026

View reviewed changes

Joannis pushed a commit that referenced this pull request Jan 26, 2026

Address PR #234 review feedback

211af1d

Joannis mentioned this pull request Jan 26, 2026

WIP: Listen into BLE accessoiries #272

Draft

Bluetooth CLI actions, pair/trust connect #234

Are you sure you want to change the base?

Bluetooth CLI actions, pair/trust connect #234

Uh oh!

Conversation

zamderax commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

codecov bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zamderax commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zamderax commented Dec 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zamderax commented Dec 27, 2025 •

edited

Loading

codecov bot commented Dec 27, 2025 •

edited

Loading

zamderax commented Dec 28, 2025 •

edited

Loading