Fix to allow for use with PHP8#118
Open
gforsythe-godaddy wants to merge 2 commits intowilldurand:masterfrom
Open
Fix to allow for use with PHP8#118gforsythe-godaddy wants to merge 2 commits intowilldurand:masterfrom
gforsythe-godaddy wants to merge 2 commits intowilldurand:masterfrom
Conversation
Author
|
@willdurand (or any other maintainers) any chance at pulling this? |
|
Hello @willdurand can we accept this change? This is a very simple one that fixes few bugs for a very cheap cost. Note that this bug still exist: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code had a method named "match" which is now a restricted name.