Add method annotation to the interface#122
Open
VincentLanglet wants to merge 1 commit intowilldurand:masterfrom
Open
Add method annotation to the interface#122VincentLanglet wants to merge 1 commit intowilldurand:masterfrom
VincentLanglet wants to merge 1 commit intowilldurand:masterfrom
Conversation
Author
|
Friendly ping @willdurand, if you can take a look :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @willdurand,
When the interface was introduced in 544d268, it was empty.
But the interface should declare all the accessible methods in AcceptHeader.
Since it's base on BaseAccept, I copied the method ; I also fixed the phpdoc.
I use
@methodannotation to keep BC.The real method should be added in the 4.0 version.
Thanks for your time.