feat: add GitHub Actions CI/CD and packaging infrastructure #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add release workflow for macOS (ARM64/x64) and Linux builds - Add CI workflow for PRs with fmt, clippy, build, and test - Add pre-built binary installation instructions to README - Update README metadata.json example to match actual output format - Mark backlog items #5, #6, #13 as resolved (metadata already implemented)
- Add ADR 004: GitHub Actions for Releases - Move planning docs to .plan/.done/ - Bump version to 1.1.0
The action dtolnay/rust-action does not exist. The correct action is dtolnay/rust-toolchain.
Apply rustfmt to resolve CI formatting check failures: - output.rs: fix closure and function call formatting - segmentation.rs: fix line length issues - video.rs: fix imgproc::cvt_color call formatting
Continue applying rustfmt formatting to pass CI checks.
The opencv crate's build script requires libclang for code generation. Install llvm and set LIBCLANG_PATH environment variable.
- Use #[derive(Default)] with #[default] attribute for DetailLevel and QualityPreset - Replace iter().cloned().collect() with to_vec() in embeddings.rs - Use is_multiple_of() instead of manual modulo check in video.rs - Prefix unused start_idx parameter with underscore in segmentation.rs Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add #[allow(dead_code)] for intentionally exposed public API items - Prefix unused loop variables with underscore (batch_idx, end) - These items are part of the public API and may be used externally Co-Authored-By: Claude Opus 4.5 <[email protected]>
Remove .enumerate() since batch_idx is unused. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
GitHub Actions Workflows
release.yml): Triggered on version tags (v*), builds for macOS ARM64, macOS x64, and Linux x64ci.yml): Runs on PRs withcargo fmt --check,cargo clippy,cargo build, andcargo testREADME Updates
Backlog Items Resolved
output.rsADR
Test plan
v1.1.0to trigger release workflow