Fixed issue where selection did not update after clicking on shape#3090
Merged
breiler merged 2 commits intowinder:masterfrom Apr 25, 2026
Merged
Fixed issue where selection did not update after clicking on shape#3090breiler merged 2 commits intowinder:masterfrom
breiler merged 2 commits intowinder:masterfrom
Conversation
Selection is only populated itself from SelectionListener events. But DesignerTopComponent.onSelectionEvent opens the settings pane via SwingUtilities.invokeLater, so SettingsTopComponent.componentOpened runs after the SelectionEvent has already been dispatched. A fresh SelectionSettingsPanel then registers as a listener with no way to learn about the just-selected shape, leaving the pane empty and disabled
Contributor
Author
|
There appear to be issues with the "Shape settings" after i refreshed from main today. If you have any idea what the remaining issue is I can attempt to fix next week otherwise I might have to revert to an older version. 
|
Contributor
Author
|
Todays commit has my fork properly loading the shape settings in the designer when launching from ./run_platform.sh 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selection is only populated itself from SelectionListener events. But DesignerTopComponent.onSelectionEvent opens the settings pane via SwingUtilities.invokeLater, so SettingsTopComponent.componentOpened runs after the SelectionEvent has already been dispatched. A fresh SelectionSettingsPanel then registers as a listener with no way to learn about the just-selected shape, leaving the pane empty and disabled