fix(jseval): increase QuickJS memory limit from 32MB to 256MB#9860
Open
salarkhannn wants to merge 1 commit into
Open
fix(jseval): increase QuickJS memory limit from 32MB to 256MB#9860salarkhannn wants to merge 1 commit into
salarkhannn wants to merge 1 commit into
Conversation
Flow expression evaluation uses QuickJS to evaluate step input
transforms. The 32MB memory limit was too restrictive for payloads
that construct large arrays — e.g. Array.from({length: 1e6}, ...).flat()
exceeds 32MB and causes QuickJS to throw 'Exception generated by
quickjs' which surfaces as an opaque eval failure.
Increase the limit to 256MB. This is safe because QuickJS evaluations
are always authenticated, run inside the worker's per-job isolation,
and 256MB is well within typical server capacity.
Closes windmill-labs#8073.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow expression evaluation uses QuickJS to evaluate step input transforms. The 32MB memory limit was too restrictive for payloads that construct large arrays — for example
Array.from({length: 1e6}, ...).flat()exceeds 32MB and causes QuickJS to throwException generated by quickjs, surfacing as an opaque eval failure.Increasing the limit to 256MB. QuickJS evaluations are always authenticated and run inside the worker per-job isolation, so this is safe.
Closes #8073.
Summary by cubic
Increase the QuickJS memory limit for flow expression evaluation from 32MB to 256MB to prevent opaque eval failures on large payloads (e.g., million-element arrays). Evaluations are authenticated and run in per‑job isolated workers, so this increase is safe.
Written for commit 5c5b6b9. Summary will update on new commits.