Closed
Conversation
Member
Contributor
Author
|
Hmm, I'm wondering if this would then work with setuptools < 81? Maybe better to inspect if CCompiler.init has a dry_run arg (<81) then pass the arg and if not (>=81) then don't. |
Member
|
Hi @ladaapp, it should work because we are passing in keyword arguments with the patched version and all the arguments in <81 and >=81 are optional. You can see the change in the |
Contributor
Author
|
Okay cool, even better. Thanks for the fix then. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, recent version of setuptools breaks gobject-introspection build (https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/575)
Locally I fixed this via
So I think for now it's probably best to restrict setuptools upper version
You can see the error also in this PR from dependabot #1717 which updated to latest setuptools