fix: alignment and translation issue on 'missing call from' cell - WPB-22560#4486
Open
JaCaLlaSchwarz wants to merge 6 commits intodevelopfrom
Open
fix: alignment and translation issue on 'missing call from' cell - WPB-22560#4486JaCaLlaSchwarz wants to merge 6 commits intodevelopfrom
JaCaLlaSchwarz wants to merge 6 commits intodevelopfrom
Conversation
Contributor
Test Results1 876 tests 1 849 ✅ 2m 6s ⏱️ Results for commit 0521687. ♻️ This comment has been updated with latest results. Summary: workflow run #23656976978 |
johnxnguyen
approved these changes
Mar 25, 2026
samwyndham
requested changes
Mar 25, 2026
Contributor
samwyndham
left a comment
There was a problem hiding this comment.
I think we might not be using stringsdicts correctly and to there full potential here. Let me know if you disagree.
wire-ios/Wire-iOS/Resources/Localization/Base.lproj/Localizable.stringsdict
Show resolved
Hide resolved
...Cells/ConfigurationMessageCell/Components/ConversationMissedCallSystemMessageViewModel.swift
Show resolved
Hide resolved
ad06840 to
7d9c04e
Compare
7d9c04e to
5f85461
Compare
samwyndham
reviewed
Mar 27, 2026
| <string>d</string> | ||
| <key>one</key> | ||
| <string>Missed call from %2$@</string> | ||
| <string>مكالمة مفقودة منة مفقودة من</string> |
Contributor
There was a problem hiding this comment.
issue: Is this accidentally committed debug code or where does the translation come from?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
Missing call conversation cell was not presented properly:
Testing
Visual validation.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: