Skip to content

fix: alignment and translation issue on 'missing call from' cell - WPB-22560#4486

Open
JaCaLlaSchwarz wants to merge 6 commits intodevelopfrom
fix/missing_call_cell_message_and_alingment_WPB-22560
Open

fix: alignment and translation issue on 'missing call from' cell - WPB-22560#4486
JaCaLlaSchwarz wants to merge 6 commits intodevelopfrom
fix/missing_call_cell_message_and_alingment_WPB-22560

Conversation

@JaCaLlaSchwarz
Copy link
Copy Markdown
Collaborator

@JaCaLlaSchwarz JaCaLlaSchwarz commented Mar 25, 2026

BugWPB-22560 [iOS] Misaligned tick mark shown agains missed call system message on opening the keyboard

Issue

Missing call conversation cell was not presented properly:

image
  • Translation is not presented.

Testing

Visual validation.

Case Before After
Translation fix image  image
Left hand side language - Arabic   image
Centered language - Chinese Simplified    image
Centered language - Chinese Traditional image

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@JaCaLlaSchwarz JaCaLlaSchwarz marked this pull request as ready for review March 25, 2026 10:27
@netbe netbe changed the title fix: Alingment and translation issue on 'missing call from' cell - WPB-22560 fix: alignment and translation issue on 'missing call from' cell - WPB-22560 Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

Test Results

1 876 tests   1 849 ✅  2m 6s ⏱️
  300 suites     27 💤
    1 files        0 ❌

Results for commit 0521687.

♻️ This comment has been updated with latest results.

Summary: workflow run #23656976978
Allure report (download zip): html-report-28864-fix_missing_call_cell_message_and_alingment_WPB-22560

Copy link
Copy Markdown
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might not be using stringsdicts correctly and to there full potential here. Let me know if you disagree.

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp bot commented Mar 27, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0521687 | Docs | Was this helpful? Give us feedback!

@JaCaLlaSchwarz JaCaLlaSchwarz force-pushed the fix/missing_call_cell_message_and_alingment_WPB-22560 branch from ad06840 to 7d9c04e Compare March 27, 2026 11:50
@JaCaLlaSchwarz JaCaLlaSchwarz force-pushed the fix/missing_call_cell_message_and_alingment_WPB-22560 branch from 7d9c04e to 5f85461 Compare March 27, 2026 11:53
<string>d</string>
<key>one</key>
<string>Missed call from %2$@</string>
<string>مكالمة مفقودة منة مفقودة من</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Is this accidentally committed debug code or where does the translation come from?

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants