Conversation
Note that the config reload button text (`text.owo.config.button.reload`) does not fit the reload button, so I had to contract it. You might want to fix that in the mod so that the button gets its size from its content or something like that, I'm not that experienced in the UI part of the mod yet.
Co-authored-by: VladisCrafter <122053125+VladisCrafter@users.noreply.github.com>
|
Hi, all of the suggestions are great, I've applied them all. Though IDK when the PR will be approved, that's on the repo maintainers. |
|
According to this message from @Dragon-Seeker, this PR is pretty much ready to be merged 🙂 |
|
Btw @Bamberghh, why did you make the same PR for 1.21.5? The devs could port your commit to multiple branches themselves. |
|
@VladisCrafter IDK, I think at that time there were 2 active branches and I thought that I had to make PRs for both of them. Now that I think about it that was unnecessary since they have the same changes. Should I maybe delete the other PR? |
Yes, I think it'd be better to close the other PR since it doesn't have the requested fixes yet can be merged by mistake which is definitely not good. |
2 participants
Note that the config reload button text (
text.owo.config.button.reload) does not fit the reload button, so I had to contract it. You might want to fix that in the mod so that the button gets its size from its content or something like that, I'm not that experienced in the UI part of the mod yet.