Skip to content

Fix regression in renode container#741

Closed
danielinux wants to merge 0 commit intowolfSSL:masterfrom
danielinux:fix-renode-regression
Closed

Fix regression in renode container#741
danielinux wants to merge 0 commit intowolfSSL:masterfrom
danielinux:fix-renode-regression

Conversation

@danielinux
Copy link
Copy Markdown
Member

  • tagging to previous 1.15 version since 1.16 seems broken
  • Enforcing nrf52 config set/restore for renode runs

Copilot AI review requested due to automatic review settings March 30, 2026 13:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the Renode container image to a known-good version and makes Renode test runs enforce a specific nRF52 build configuration while restoring any pre-existing repo .config afterward.

Changes:

  • Pin Renode container base image to antmicro/renode:1.15.3 to avoid regressions in newer images.
  • Add .config backup/restore flow to renode-test-update.sh and force config/examples/nrf52840.config for Renode runs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tools/scripts/renode-test-update.sh Backs up/restores .config and forces the nRF52840 example config before building/running Renode tests.
tools/renode/Dockerfile Pins Renode base image to version 1.15.3 instead of latest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +25 to +26
RENODE_CONFIG_BACKUP=$(mktemp /tmp/wolfboot-renode-config.XXXXXX)
cp .config "$RENODE_CONFIG_BACKUP"
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepare_build_config can accidentally delete the user’s pre-existing .config if mktemp or cp .config "$RENODE_CONFIG_BACKUP" fails (because RENODE_CONFIG_BACKUP is set before verifying the backup file was successfully created). On exit, restore_build_config will then fall back to rm -f .config, losing the original configuration. Consider only setting RENODE_CONFIG_BACKUP after a successful copy (or aborting the script on backup failure) so the original .config is never destroyed.

Suggested change
RENODE_CONFIG_BACKUP=$(mktemp /tmp/wolfboot-renode-config.XXXXXX)
cp .config "$RENODE_CONFIG_BACKUP"
local backup
backup=$(mktemp /tmp/wolfboot-renode-config.XXXXXX) || {
echo "Failed to create temporary backup for existing .config; aborting." >&2
exit 1
}
if ! cp .config "$backup"; then
echo "Failed to backup existing .config to $backup; aborting." >&2
rm -f "$backup"
exit 1
fi
RENODE_CONFIG_BACKUP="$backup"

Copilot uses AI. Check for mistakes.
@danielinux danielinux closed this Mar 30, 2026
@danielinux danielinux force-pushed the fix-renode-regression branch from fd748ba to e30ca2d Compare March 30, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants