Add fenrir suggested test cases

[embhorn]

Update for ChangeLog.md at release:

• API Changes
  - MqttEncode_Props: STRING and STRING_PAIR property types now require the
  caller to set data_str.len (and data_str2.len for STRING_PAIR)
  explicitly. Previously the length was derived internally via XSTRLEN on
  data_str.str. Applications that only populated data_str.str and
  relied on strlen will now emit zero-length property strings. Update
  callers to set prop->data_str.len = (word16)XSTRLEN(prop->data_str.str);
  (or the actual byte length) before encoding. Affects v5 properties such
  as AUTH_METHOD, CONTENT_TYPE, RESPONSE_TOPIC, USER_PROPERTY, etc.

• Update AGENTS.md with testing directives
• Fix f-2359 Subscribe encode/decode tests
• Fix f-2348 Keepalive timeout tests
• Fix f-2349 BrokerHandle_Subscribe tests
• Fix f-2360 MqttEncode_String bug and tests
• Fix f-2363 MqttEncode_Unsubscribe tests
• Fix f-2744 MqttDecode_Publish tests
• Fix f-2745 MqttEncode_FixedHeader tests
• Fix f-2746 MqttEncode_Connect tests
• Fix f-2747 MqttEncode_Vbi tests
• Fix f-2748 MqttEncode_PublishResp tests
• Fix f-2749 MqttDecode_SubscribeAck tests
• Fix f-2750 MqttEncode_Un/Subscribe tests
• Fix f-2757 MqttDecode_Auth bug and tests
• Fix f-3130 MqttDecode_Connect tests
• Fix f-3131 MqttClient_Connect cred clearing tests

[Copilot]

Pull request overview

Adds new unit tests targeting MqttDecode_Publish (including edge/malformed cases and an MQTT v5 property scenario) and updates contributor/agent guidance around test integrity and reporting discipline.

Changes:

• Add multiple MqttDecode_Publish test cases for QoS0/QoS1, zero-payload, and malformed remaining-length handling.
• Add an MQTT v5 PUBLISH decode test that exercises property parsing and frees decoded properties.
• Extend AGENTS.md with guidance on test integrity, non-fabrication, and exit-code discipline.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tests/test_mqtt_packet.c	Adds new MqttDecode_Publish unit tests and registers them in the test runner (incl. v5 properties case).
AGENTS.md	Introduces new test/reporting integrity guidelines for contributors/agents.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #484

Scan targets checked: wolfmqtt-bugs, wolfmqtt-src

No new issues found in the changed files. ✅

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[aidangarske]

Skoll Multi-Scan Review

Modes: review + review-security + audit
Overall recommendation: COMMENT
Findings: 7 total — 7 posted, 0 skipped
7 finding(s) posted as inline comments (see file-level comments below)

Posted findings

• [SUGGEST] [review] AGENTS.md test-vector section references tools/formats that do not apply to wolfMQTT — AGENTS.md:169-175
• [Info] [review+review-security] t6b keep-alive test continues after watcher/client fail to become ready and timing clock starts before kill -STOP — scripts/broker.test:335-378
• [SUGGEST] [review] t6b timing window is tight and may flake on loaded CI — scripts/broker.test:313-334
• [NIT] [review] Oversized-string tests allocate ~64KB on the heap several times per run — tests/test_mqtt_packet.c:445-470, 957-983, 986-1011, 1014-1039, 1042-1067, 1070-1096
• [NIT] [review] connect_clears_tx_buf_credentials depends on undefined behavior if write returns early — tests/test_mqtt_client.c:330-386
• [Info] [review-security] MqttDecode_Auth returns OUT_OF_BUFFER instead of MALFORMED_DATA for invalid reason codes — src/mqtt_packet.c:2762-2764
• [NIT] [audit] MqttEncode_Subscribe oversized-topic check not tested at non-first loop index — src/mqtt_packet.c:1752-1767

Review generated by Skoll