Exit MatchDomainName if pattern or string length reach 0.#10119
Merged
douzzer merged 2 commits intowolfSSL:masterfrom Apr 3, 2026
Merged
Exit MatchDomainName if pattern or string length reach 0.#10119douzzer merged 2 commits intowolfSSL:masterfrom
douzzer merged 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses zd#21512 by updating the hostname/pattern matching loop in MatchDomainName() to stop processing when either the pattern or input string length reaches zero, aiming to prevent out-of-bounds reads during hostname verification.
Changes:
- Update
MatchDomainName()main loop condition to also requirestrLen > 0before continuing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Retest this please |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/internal.c:1
- The PR title says "Exit MatchDomainName if pattern or string length reach 0.", but this change only adds a guard for
strLen == 0. Either update the PR title/description to reflect the actual scope, or add the correspondingpatternLenguard at the point(s) wherepatternis dereferenced to fully match the stated intent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
douzzer
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21512.
Thanks to Zou Dikai for the report!
Testing
Tested using provided reproducer.
Checklist