Option in adv guide to print yaml advisory to console#1077
Open
jdolitsky wants to merge 1 commit intowolfi-dev:mainfrom
Open
Option in adv guide to print yaml advisory to console#1077jdolitsky wants to merge 1 commit intowolfi-dev:mainfrom
jdolitsky wants to merge 1 commit intowolfi-dev:mainfrom
Conversation
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky
commented
Jul 24, 2024
Comment on lines
+39
to
42
| // if req.VulnerabilityID != "" { | ||
| // return errors.New("vulnerability should be empty") | ||
| // } | ||
|
|
Member
Author
There was a problem hiding this comment.
This seems to cause wolfictl adv guide to crash with
2024/07/23 21:35:03 ERRO adding advisory data: creating advisory: vulnerability should be empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the "submit PR" function requires a GITHUB_TOKEN (correct?) so this PR allows the user to simply print the changed YAMLs to the console to submit to advisory repo themselves.