feat(scan/apk): Respect GRYPE_DB_MAX_ALLOWED_BUILT_AGE#1495
Open
EyeCantCU wants to merge 1 commit intowolfi-dev:mainfrom
Open
feat(scan/apk): Respect GRYPE_DB_MAX_ALLOWED_BUILT_AGE#1495EyeCantCU wants to merge 1 commit intowolfi-dev:mainfrom
EyeCantCU wants to merge 1 commit intowolfi-dev:mainfrom
Conversation
There was about a one hour window of time where I couldn't scan Hadoop or gRPC while working through vulnerabilities without possibly building the database locally (because it hadn't been updated yet) so I took a quick look at how we handle this in wolfictl and found it deviates from the behavior in grype Similar to grype, respect GRYPE_DB_MAX_ALLOWED_BUILT_AGE so that users can set this to whatever their preferred duration is. Default to 24 hours Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
hectorj2f
requested changes
Mar 14, 2025
Member
hectorj2f
left a comment
hectorj2f
left a comment
There was a problem hiding this comment.
Could we add this as a flag? So this doesn't get hidden into the code. That way we could add some documentation about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was about a one hour window of time where I couldn't scan Hadoop or gRPC while working through vulnerabilities without possibly building the database locally (because it hadn't been updated yet) so I took a quick look at how we handle this in wolfictl and found it deviates from the behavior in grype
Similar to grype, respect GRYPE_DB_MAX_ALLOWED_BUILT_AGE so that users can set this to whatever their preferred duration is. Default to 24 hours