Fix an issue with button "Done" sometimes disappearing when you entering password for post when publishing #25138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
force-pushed
the
task/status-row-in-publishing-sheet
branch
from
b9d6a67 to
1a75fb0
Compare
kean
commented
Jan 13, 2026
|
|
||
| @ViewBuilder | ||
| private var enterPasswordRows: some View { | ||
| PasswordField(password: $selection.password, isFocused: isPasswordFieldFocused) |
Contributor
Author
There was a problem hiding this comment.
Here we removed quite a bit of duplication.
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30464 | |
| Version | PR #25138 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 4234f4e | |
| Installation URL | 6en3dkg60lee8 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30464 | |
| Version | PR #25138 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 4234f4e | |
| Installation URL | 7dhudbiqq4hug |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
crazytonyli
approved these changes
Jan 16, 2026
| ) | ||
| NavigationLink { | ||
| SettingsPickerListView( | ||
| selection: $viewModel.settings.metadata.accessLevel, |
Contributor
There was a problem hiding this comment.
The selection "Everyone" should be selected (showing a checkmark), I think?
Contributor
Author
There was a problem hiding this comment.
Fixed. I also moved it to the leading edge – easier to see what's selected.
Tested it end-to-end, so everything still works.
kean
force-pushed
the
task/status-row-in-publishing-sheet
branch
from
73cfe58 to
4234f4e
Compare
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes CMM-809: Button "Done" disappears when you enter a password for post.
I previously attempted it in #24950, but it turned out to be too complicated. Instead of replacing "Visibility" with "Status", I now simply updated the "Enter Password" flow so it's now consistent across "Post Settings" and "Publishing" screen.
The "Visibility" row works the same as one the web, so I don't think we should touch it unless web (Gutenberg) changes it.
In addition, I fixed an issue with the new "Access" field not showing the selected value.
Recording
Screen.Recording.2026-01-13.at.3.48.32.PM.mov