Log out-of-bounds features#129
Open
jpolchlo wants to merge 3 commits into
Open
Conversation
added 3 commits
November 2, 2021 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
If inputs contain geometries that do not intersect the tree cover loss raster extent, those geometries will be lost. If the input contains only non-intersecting geometries,
ForestChangeDiagnoticCommandwill fail outright.Issue Number: N/A
What is the new behavior?
I introduce a complementary join to
ValidatedFeatureRDDthat will identify geometries that have no intersection with the tree cover loss extent, and will track their feature IDs asNoIntersectionErrors. These will be propagated into the output.Does this introduce a breaking change?
Other information
A test input containing only two out-of-bounds geometries yields the following final output: