Skip to content

Refactor emissivity calculations#108

Merged
wtbarnes merged 7 commits intomainfrom
aia-emission-refactor
Oct 11, 2025
Merged

Refactor emissivity calculations#108
wtbarnes merged 7 commits intomainfrom
aia-emission-refactor

Conversation

@wtbarnes
Copy link
Owner

@wtbarnes wtbarnes commented Oct 4, 2025

This PR does several things:

  • Refactor emissivity calculations in EmissionModel
  • Add continuum emission to narrowband emissivity (used in AIA intensity calculation)
  • Speed up loading of HYDRAD results
  • Refactor loading ionization fractions
  • Add optional mask in field-aligned coordinate for chromospheric emission

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 29.41176% with 120 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.67%. Comparing base (ae369d2) to head (2a61e52).

Files with missing lines Patch % Lines
synthesizAR/atomic/emission_models.py 18.36% 80 Missing ⚠️
synthesizAR/interfaces/hydrad/hydrad.py 13.33% 13 Missing ⚠️
synthesizAR/instruments/sdo.py 42.10% 11 Missing ⚠️
synthesizAR/strand.py 28.57% 10 Missing ⚠️
synthesizAR/skeleton.py 69.23% 4 Missing ⚠️
synthesizAR/instruments/base.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   61.00%   61.67%   +0.67%     
==========================================
  Files          43       43              
  Lines        2226     2239      +13     
==========================================
+ Hits         1358     1381      +23     
+ Misses        868      858      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wtbarnes wtbarnes marked this pull request as ready for review October 11, 2025 17:51
@wtbarnes wtbarnes merged commit 95df5b5 into main Oct 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants