Skip to content

Update scala-library to 3.8.1 #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xerial-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Update scala-library to 3.8.1 #4151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airspec/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ addCommandAlias(
Global / onChangedBuildSource := ReloadOnSourceChanges

val SCALA_2_12 = "2.12.21"
val SCALA_2_13 = "2.13.18"
val SCALA_2_13 = "3.8.1"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The variable SCALA_2_13 is now assigned the value "3.8.1". This naming is misleading as it suggests a Scala 2.13 version, but it actually holds a Scala 3 version. This can cause confusion and potential issues if other parts of the build system rely on this variable name to determine the Scala major version. Please rename this variable to accurately reflect the Scala version it represents, for example, SCALA_3_8_1 or SCALA_3_LATEST if it's intended to be the latest Scala 3 version.

val SCALA_3_8_1         = "3.8.1"

val SCALA_3 = "3.3.7"
val targetScalaVersions = SCALA_3 :: SCALA_2_13 :: SCALA_2_12 :: Nil

Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import scalajsbundler.JSDOMNodeJSEnv
import xerial.sbt.pack.PackPlugin.{projectSettings, publishPackArchiveTgz}

val SCALA_2_12 = "2.12.21"
val SCALA_2_13 = "2.13.18"
val SCALA_2_13 = "3.8.1"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to airspec/build.sbt, the variable SCALA_2_13 is assigned the value "3.8.1". This is a naming inconsistency that can lead to confusion and incorrect assumptions about the Scala version being used. It should be renamed to reflect that it's a Scala 3 version.

val SCALA_3_8_1         = "3.8.1"

val SCALA_3 = sys.env.getOrElse("SCALA_VERSION", "3.3.7")
val uptoScala2 = SCALA_2_13 :: SCALA_2_12 :: Nil
val targetScalaVersions = SCALA_3 :: uptoScala2
Expand Down
2 changes: 1 addition & 1 deletion examples/rx-demo/gallery/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Global / onChangedBuildSource := ReloadOnSourceChanges

val AIRFRAME_VERSION = "2025.1.27"
ThisBuild / scalaVersion := "2.13.18"
ThisBuild / scalaVersion := "3.8.1"

lazy val gallery =
project
Expand Down
Loading