Skip to content

autotools, darwin: restrict -force_cpusubtype_ALL switch to powerpc only#109

Open
sezero wants to merge 1 commit into
xiph:mainfrom
sezero:darwin0
Open

autotools, darwin: restrict -force_cpusubtype_ALL switch to powerpc only#109
sezero wants to merge 1 commit into
xiph:mainfrom
sezero:darwin0

Conversation

@sezero

@sezero sezero commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Fixes: #107
Fixes: #108
(See also: mkxp-z/mkxp-z#200)

@Splendide-Imaginarius

Copy link
Copy Markdown

Thanks for fixing this. This GitHub repo hasn't gotten any commits in 3 years. Maybe try submitting this fix to https://gitlab.xiph.org/xiph/vorbis (last commit was a month ago)?

@sezero

sezero commented Jul 30, 2024

Copy link
Copy Markdown
Contributor Author

This GitHub repo hasn't gotten any commits in 3 years. Maybe try submitting this fix to https://gitlab.xiph.org/xiph/vorbis (last commit was a month ago)?

I don't intend to, at the moment. But if you can post a notifier at there, please do so.

@sezero

sezero commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for fixing this. This GitHub repo hasn't gotten any commits in 3 years. Maybe try submitting this fix to https://gitlab.xiph.org/xiph/vorbis (last commit was a month ago)?

https://gitlab.xiph.org/xiph/vorbis/-/issues/2352

@Splendide-Imaginarius

Copy link
Copy Markdown

@sezero Is it likely that SDL_mixer will pull in this fix if upstream doesn't review your PR?

@sezero

sezero commented Sep 28, 2024

Copy link
Copy Markdown
Contributor Author

@sezero Is it likely that SDL_mixer will pull in this fix if upstream doesn't review your PR?

I can apply it to SDL's vendored libvorbis, but when SDL_mixer is built in vendored mode it uses cmake and not autotools (the issue and the fix is autotools-only), therefore no point in that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building on macos arm through rosetta terminal causes ld: unknown option

2 participants