Open
Conversation
corrected some linguistic mistakes
nkrkv
requested changes
Oct 13, 2020
Member
nkrkv
left a comment
nkrkv
left a comment
There was a problem hiding this comment.
Thanks for the PR! I see some issues with it though. If you can fix them, it would be super-nice. Or, if you want, we can fix them on your behalf.
| You should have received a copy of the GNU Affero General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| As a special exception, the copyright holders give permission to link the code of portions of this program with the OpenSSL library under certain conditions as described in each individual source file and distribute linked combinations including the program with the OpenSSL library. You must comply with the GNU Affero General Public License in all respects for all of the code used other than as permitted herein. If you modify file(s) with this exception, you may extend this exception to your version of the file(s), but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. If you delete this exception statement from all source files in the program, then also delete it in the license file. | ||
| As a special exception, the copyright holders permission to link the code of portions of this program with the OpenSSL library under certain conditions as described in each individual source file and distribute linked combinations including the program with the OpenSSL library. You must comply with the GNU Affero General Public License in all respects for all of the code used other than as permitted herein. If you modify the file(s) with this exception, you may extend this exception to your version of the file(s), but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. If you delete this exception statement from all source files in the program, then also delete it in the license file. |
Member
There was a problem hiding this comment.
This is a legal copy-paste. An excerpt from the official AGPL license text. I’d prefer not to touch this.
| * `yarn start:electron` — starts desktop IDE | ||
| * `yarn start:spectron-repl` — starts functional tests environment | ||
| * `yarn storybook` — starts React components viewer for visual inspection | ||
| * `yarn storybook` — starts to React components viewer for visual inspection |
Member
There was a problem hiding this comment.
I think the is more appropriate here.
Comment on lines
+55
to
+58
| * `yarn build: electron` — build desktop IDE only | ||
| * `yarn build:cli` — build CLI tools only | ||
| * `yarn dev:browser` — run dev-version of browser IDE on localhost | ||
| * `yarn dist:electron` — build OS-specific distributive of desktop IDE | ||
| * `yarn dev: browser` — run dev-version of browser IDE on localhost | ||
| * `yarn dist: electron` — build OS-specific distributive of desktop IDE |
Member
There was a problem hiding this comment.
Having no space after the colons is Yarn specifics. Shouldn’t be changed.
|
|
||
| ```bash | ||
| yarn start:electron | ||
| yarn start: electron |
Member
There was a problem hiding this comment.
Having no space after the colons is Yarn specifics. Shouldn’t be changed.
|
|
||
| ```bash | ||
| yarn dev:browser | ||
| yarn dev: browser |
Member
There was a problem hiding this comment.
Having no space after the colons is Yarn specifics. Shouldn’t be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrected some linguistic mistakes