Allow empty string to be passed as message text for Slack Incoming Webhooks; disallow null#18
Open
savethefails wants to merge 1 commit intoxoxco:masterfrom
Open
Allow empty string to be passed as message text for Slack Incoming Webhooks; disallow null#18savethefails wants to merge 1 commit intoxoxco:masterfrom
savethefails wants to merge 1 commit intoxoxco:masterfrom
Conversation
Author
|
Hi @benbrown. Wondering if you can pull this in? |
geekmuse
approved these changes
May 22, 2020
Author
|
@geekmuse that was unexpected! |
|
Totally unintentional! Sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack allows an empty string to be passed as the text parameter to an incoming webhook, but in
Slack.prototype.sendthe codeif (!message.text)evaluates to true ifmessage.text == ''and so no request is made. The pull request changes the conditional to check that the message text isn't null instead of casting an empty string into a boolean.