Conversation
$nr_of_rows and $pages_per_set where respectively set to 5 and 7
in several files.
Since $nr_of_rows was set to config->{posts_on_page} in
lib/PearlBee/Posts.pm, the obvious fix was to follow that example and
make those values configurable in the main config.yml.
Defaults are assigned at the application startup, so there is no need
to further check if the values are valid.
posts_on_page still has a number of issues:
- it should probably be named posts_per_page
- it is actually used different things, like limiting the number of
users or comments shown in the dashboard
Further improvements include the addition of users_per_page,
comments_per_page, etc.
andrewalker
pushed a commit
to andrewalker/PearlBee
that referenced
this pull request
Nov 18, 2017
added changed filles (js for toggle)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$nr_of_rowsand$pages_per_setwhere respectively set to 5 and 7in several files.
Since
$nr_of_rowswas set toconfig->{posts_on_page}inlib/PearlBee/Posts.pm, the obvious fix was to follow that example andmake those values configurable in the main
config.yml.Defaults are assigned at the application startup, so there is no need
to further check if the values are valid.
posts_on_pagestill has a number of issues:posts_per_pageusers or comments shown in the dashboard
Further improvements include the addition of
users_per_page,comments_per_page, etc.This fixes #1.