You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All tests pass (Didn't run it since I am not change the lib source)
I have run npm run doc
Description
Changed the examples and README.md since lots of people wrote codes with copying the example, which might cause the bot to match URL or other things.
Generally, the only thing that should consider as a command is a string start with special character (in this case "/")
Therefore, the following should be considering as a command
/echo 123
/help
but not these
I found a file under /bin, which is /bin/echo What is is file for in Linux?
http://help.google.com/
@kamikazechaser I did consider that, but since there might be something like /command@botname, and regex will be ^\/command(@.*|$).
I don't think complexing the example is a good idea then.
Therefore, I was not adding that to the PR, or should I?
@danielperez9430
Well, I will simply ignore the argument for the commands that doesn't require args.
but for something like /echo, I did use ^\/echo(?:@.*?)? (.+), or you prefer ^\/echo(?:@.*?)?( .*|$) ?
Btw I meant the regex terminator here, not adding @botname to the regex. Otherwise the PR is okay after that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run docDescription
Changed the examples and README.md since lots of people wrote codes with copying the example, which might cause the bot to match URL or other things.
Generally, the only thing that should consider as a command is a string start with special character (in this case "/")
Therefore, the following should be considering as a command
but not these
Using the original example will resulting as

References
Nope