Address issue 23 with constructor patch to library#24
Open
qbarnes wants to merge 2 commits intoyahoo:masterfrom
Open
Address issue 23 with constructor patch to library#24qbarnes wants to merge 2 commits intoyahoo:masterfrom
qbarnes wants to merge 2 commits intoyahoo:masterfrom
Conversation
time ago and now causes a duplicate symbol build failure on newer distros. Switch to using "__attribute__((constructor))". Tested change successfully as far back as Debian 10, Ubuntu 16.04, and CentOS/RHEL 7.
no longer allow specifying INPUT chains. Change to PREROUTING.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
I think upstreaming these two commits will address Issue #23.
I believe the old "verizonmedia.com" email addresses should be updated in the source and docs at some point. With this patch, I still left it in the old style.