simplify tracking api with faces input and output#84
Closed
hardikdava wants to merge 1 commit intoyakhyo:mainfrom
Closed
simplify tracking api with faces input and output#84hardikdava wants to merge 1 commit intoyakhyo:mainfrom
hardikdava wants to merge 1 commit intoyakhyo:mainfrom
Conversation
Author
|
@yakhyo can you review this PR please? |
Owner
|
Hi @hardikdava , sorry for late reply. Mmm, since the face tracking is challenging so I was going to keep the Tracker AS IS and standalone. So modifying inside may not really good, that is what I thought after having some experiments. I appreciate your efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @yakhyo this PR modifies tracker implementation by adding a new method which accepts detected faces as input and returns tracked faces. This give more simplified approach to handle tracker. Let me know wdyt?