Skip to content

Update log messages in the session pools#650

Open
alex268 wants to merge 1 commit into
ydb-platform:masterfrom
alex268:master
Open

Update log messages in the session pools#650
alex268 wants to merge 1 commit into
ydb-platform:masterfrom
alex268:master

Conversation

@alex268
Copy link
Copy Markdown
Member

@alex268 alex268 commented May 14, 2026

No description provided.

Comment thread table/src/main/java/tech/ydb/table/impl/pool/StatefulSession.java
@pnv1 pnv1 requested a review from Copilot May 14, 2026 13:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates session pool logging to improve signal/noise and add visibility into key lifecycle events (broken sessions and idle-timeout removals).

Changes:

  • Downgrade some high-frequency logs from debug to trace in table SessionPool.
  • Add new debug logs when sessions become broken (table) and when sessions are removed due to idle timeout (table/query).
  • Fix typo in query session close log message (“broke” → “broken”).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
table/src/main/java/tech/ydb/table/impl/pool/StatefulSession.java Adds debug logs when a session transitions to broken/needs-shutdown due to status/shutdown hint.
table/src/main/java/tech/ydb/table/impl/pool/SessionPool.java Lowers verbosity for acquire/accept logs; adds idle-timeout removal log.
query/src/main/java/tech/ydb/query/impl/SessionPool.java Fixes close log typo; adds idle-timeout removal log.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread query/src/main/java/tech/ydb/query/impl/SessionPool.java Outdated
Comment thread table/src/main/java/tech/ydb/table/impl/pool/SessionPool.java Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.24%. Comparing base (a422551) to head (d02fb60).

Files with missing lines Patch % Lines
...src/main/java/tech/ydb/query/impl/SessionPool.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #650      +/-   ##
============================================
- Coverage     71.32%   71.24%   -0.09%     
+ Complexity     3364     3361       -3     
============================================
  Files           379      379              
  Lines         15916    15920       +4     
  Branches       1669     1669              
============================================
- Hits          11352    11342      -10     
- Misses         3914     3923       +9     
- Partials        650      655       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants