Update log messages in the session pools#650
Open
alex268 wants to merge 1 commit into
Open
Conversation
pnv1
reviewed
May 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates session pool logging to improve signal/noise and add visibility into key lifecycle events (broken sessions and idle-timeout removals).
Changes:
- Downgrade some high-frequency logs from
debugtotracein tableSessionPool. - Add new
debuglogs when sessions become broken (table) and when sessions are removed due to idle timeout (table/query). - Fix typo in query session close log message (“broke” → “broken”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| table/src/main/java/tech/ydb/table/impl/pool/StatefulSession.java | Adds debug logs when a session transitions to broken/needs-shutdown due to status/shutdown hint. |
| table/src/main/java/tech/ydb/table/impl/pool/SessionPool.java | Lowers verbosity for acquire/accept logs; adds idle-timeout removal log. |
| query/src/main/java/tech/ydb/query/impl/SessionPool.java | Fixes close log typo; adds idle-timeout removal log. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
============================================
- Coverage 71.32% 71.24% -0.09%
+ Complexity 3364 3361 -3
============================================
Files 379 379
Lines 15916 15920 +4
Branches 1669 1669
============================================
- Hits 11352 11342 -10
- Misses 3914 3923 +9
- Partials 650 655 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pnv1
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.