prevent double free in WRITEFUNCTION_BUF#111
Merged
nojb merged 1 commit intoygrek:masterfrom Aug 1, 2025
Merged
Conversation
Contributor
Author
|
Could this be merged please? I have another PR behind it. |
Collaborator
|
Hello, apologies for the lag (holiday season...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a potential double free in the writefunction_buf callback.
The bug is that an argument of NULL to caml_ba_alloc_dims will result in allocation even if CAML_BA_EXTERNAL is specified. We then set ba->data to a pointer managed by libcurl. This can cause both libcurl and the ocaml runtime to potentially later attempt to free this pointer.