Open
Conversation
Collaborator
|
Thanks, I'll try to take a look at it, but there's a bunch of unrelated stuff in |
Author
|
Very sorry about that, I used nix flakes to set up the environment and they must have snuck in while switching branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to use the share api to build a client that pools curl handles all with a shared state, so I created bindings to the curl share interface.
https://curl.se/libcurl/c/libcurl-share.html
I've included tests, but my c skills are basically zero, so, I'm not sure If I've stuffed something up or not.
Also I was unsure about whether to call: "caml_release_runtime_system" maybe you can advise?