Skip to content

Add support for proxy types CURLPROXY_HTTPS and CURLPROXY_HTTPS2#122

Merged
nojb merged 1 commit intoygrek:masterfrom
m-click:curlproxy-https-and-https2
Apr 10, 2026
Merged

Add support for proxy types CURLPROXY_HTTPS and CURLPROXY_HTTPS2#122
nojb merged 1 commit intoygrek:masterfrom
m-click:curlproxy-https-and-https2

Conversation

@vog
Copy link
Copy Markdown
Contributor

@vog vog commented Apr 10, 2026

Add support for proxy types CURLPROXY_HTTPS and CURLPROXY_HTTPS2.

Also, fix order of variants to be consistent with the libcurl documentation, and provide complete availability information.

See also:

@nojb
Copy link
Copy Markdown
Collaborator

nojb commented Apr 10, 2026

This increases to minimum required libcurl version to 8.1.0 (May 17 2023).

ocurl goes to considerable lengths to support old versions of libcurl. Can you try to implement the new feature without changing the minimum version? You can look around curl-helper.c for inspiration.

@vog vog force-pushed the curlproxy-https-and-https2 branch from 08f39ac to 606f2ea Compare April 10, 2026 09:58
@vog
Copy link
Copy Markdown
Contributor Author

vog commented Apr 10, 2026

This increases to minimum required libcurl version to 8.1.0 (May 17 2023).

ocurl goes to considerable lengths to support old versions of libcurl. Can you try to implement the new feature without changing the minimum version? You can look around curl-helper.c for inspiration.

Thanks for the hint. I just fixed that. Please review again.

@vog vog force-pushed the curlproxy-https-and-https2 branch from 606f2ea to 2ce5bb7 Compare April 10, 2026 10:47
@vog
Copy link
Copy Markdown
Contributor Author

vog commented Apr 10, 2026

@nojb I just pushed an improved version based on your feedback. Please review once again. Thank you so far for your timely feedback! 👍

Copy link
Copy Markdown
Collaborator

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nojb nojb merged commit 41bed54 into ygrek:master Apr 10, 2026
4 of 5 checks passed
@nojb
Copy link
Copy Markdown
Collaborator

nojb commented Apr 10, 2026

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants