Remove the extended BB addr map section.#305
Merged
ltratt merged 1 commit intoykjit:mainfrom Feb 9, 2026
Merged
Conversation
This section is present in "stock" LLVM: https://llvm.org/docs/Extensions.html#sht-llvm-bb-addr-map-section-basic-block-address-map We extended it to work around problems with mapping PT-reported block addresses back to IR. We no longer use hardware tracing, so we can revert the relevant sections of code back to upstream, thus minimising our diff to them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This section is present in "stock" LLVM:
https://llvm.org/docs/Extensions.html#sht-llvm-bb-addr-map-section-basic-block-address-map
We extended it to work around problems with mapping PT-reported block addresses back to IR.
We no longer use hardware tracing, so we can revert the relevant sections of code back to upstream, thus minimising our diff to them.