Bazel support#33
Open
zaucy wants to merge 1 commit into
Open
Conversation
zaucy
commented
Mar 28, 2022
Comment on lines
+2
to
+3
| name = "com_github_yohhoy_yamc", | ||
| version = "1.0.0", |
Author
There was a problem hiding this comment.
The name here is how this repository would show up to developers.
I don't know what version you would prefer here since I don't see a cut release in the repository. Let me know!
If you have any preferences please let me know or feel free to edit as you wish!
Owner
|
Thank you for big PR to support Bazel building system. Does this PR include the following purposes?
|
Author
|
Yes to both! I'm happy to answer any questions about bazel and how someone might use yamc with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I was wondering if you'd be willing to accept the bazel build system support I created upstream. If there were any issues in the future I'd be willing to contribute further. I also added some files necessary to support the bazel central registry for easily adding your library to others bazel based projects.
My comments below are only questions if you are willing to merge this in. I understand if you're unwiling to introduce an additional build system to the repository.