This repository was archived by the owner on Dec 5, 2022. It is now read-only.
Correct parseTemplate type, and requestFragment type and initialisation#328
Open
atkinchris wants to merge 6 commits intozalando:masterfrom
Open
Correct parseTemplate type, and requestFragment type and initialisation#328atkinchris wants to merge 6 commits intozalando:masterfrom
atkinchris wants to merge 6 commits intozalando:masterfrom
Conversation
This corrects the type definition for requestFragment, which does not match it's implementation. This resolves zalando#327 and supercedes https://github.com/zalando/tailor/pull/297/files. This also correct initialisation of custom `requestFragment` functions, which otherwise are not invoked to close over `filterHeaders`.
atkinchris
changed the title
Author
|
The tests are failing on Node 12, but not on earlier versions (on Travis and local). Is this related to #322? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the type definition for requestFragment, which does not match it's implementation. This resolves #327 and closes #297.
This also corrects initialisation of custom
requestFragmentfunctions, which otherwise are not invoked to close overfilterHeaders.This also corrects the type definition for
parseTemplateand resolves #329.